search

richelbilderbeek / djog_unos_2018

Project by the Uno's at DJOG 2018-2019: Nature Zen
GNU General Public License v3.0
6 stars 2 forks source link

Segfaults on windows #545

Closed DynCoder closed 5 years ago

DynCoder commented 5 years ago

The code 3 i had is now occuring on almost every windows device. I managed to find out it is a segmentation fault in the eat function. We need to fix this because otherwise almost nobody can do anything!

Multiple people may assign to this, however, make sure to communicate everything you do!

richelbilderbeek commented 5 years ago

On which branch can I take a look? Or is this already fixed?

DynCoder commented 5 years ago

My branch is furthest with solving this

Op ma 8 apr. 2019 20:32 schreef Richel Bilderbeek <notifications@github.com

:

On which branch can I take a look? Or is this already fixed?

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/richelbilderbeek/djog_unos_2018/issues/545#issuecomment-480951451, or mute the thread https://github.com/notifications/unsubscribe-auth/Ab-Tku1SufN32jBmAB4c0QbcU-WJrU8Dks5ve4tOgaJpZM4cgG7f .

richelbilderbeek commented 5 years ago

Will take a look tonight. Expect some extra asserts :+1:

richelbilderbeek commented 5 years ago

I see the build already fails on an assert in this Travis log.

@Joshua260403:

DynCoder commented 5 years ago

i tried litteraly everything so no it is not possible i missed this

Op di 9 apr. 2019 17:38 schreef Richel Bilderbeek <notifications@github.com

:

I see the build already fails on an assert in this Travis log https://travis-ci.org/richelbilderbeek/djog_unos_2018/jobs/517644081#L1741 .

@Joshua260403 https://github.com/Joshua260403:

  • may it be you forgot to test this in Debug mode? If yes, I think you may want to honor to fix this yourself
  • still want me to continue to look into this? Just to be sure, I can fix this tomorrow as well 👍

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/richelbilderbeek/djog_unos_2018/issues/545#issuecomment-481305452, or mute the thread https://github.com/notifications/unsubscribe-auth/Ab-TkukJ05sMWTnFNYZiER7gzrWzmFbyks5vfLQOgaJpZM4cgG7f .

richelbilderbeek commented 5 years ago

Yeah, I expected you did try everything :1st_place_medal:.

Maybe my branch is further ahead now...

What about you fix the error on my branch (on your branch), then I'll fix Tha Bug? No == fine as well.

DynCoder commented 5 years ago

What is the error exactly?

richelbilderbeek commented 5 years ago

Current error is a failed assert. Up for fixing that one? No == fine as well, I just prefer you getting more commits :+1:

DynCoder commented 5 years ago

Sure, as soon as the segfault is fixed!

Op di 9 apr. 2019 17:56 schreef Richel Bilderbeek <notifications@github.com

:

Current error is a failed assert https://travis-ci.org/richelbilderbeek/djog_unos_2018/jobs/517644081#L1741. Up for fixing that one? No == fine as well, I just prefer you getting more commits 👍

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/richelbilderbeek/djog_unos_2018/issues/545#issuecomment-481312806, or mute the thread https://github.com/notifications/unsubscribe-auth/Ab-TkmqLoQ-beNVXAFhx2WU-yaDGfwVmks5vfLhHgaJpZM4cgG7f .

richelbilderbeek commented 5 years ago

Okidokie, I will fix both then :rainbow:

richelbilderbeek commented 5 years ago

LOL:

// WARNING SEGFAULT OVER HERE!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!

I'm loving it :rainbow:

richelbilderbeek commented 5 years ago

OK, refactored, simplified, documented and const-corrected the code. Maybe the segfault is gone, but need someone to check.

@Joshua260403: could you merge my branch to yours to see if this is fixed?

richelbilderbeek commented 5 years ago

Tip: use --god, else the game closes immediately.