richelbilderbeek / djog_unos_2018

Project by the Uno's at DJOG 2018-2019: Nature Zen
GNU General Public License v3.0
6 stars 2 forks source link

Add angle class #553

Closed richelbilderbeek closed 5 years ago

richelbilderbeek commented 5 years ago

Is your feature request related to a problem? Please describe.

A tile has both a coordinate and an angle. Both are doubles, thus easily confused.

Describe the solution you'd like

Make a very simple angle class with a test_angle functions.

void test_angle()
{
  const double x = 123.456;
  const angle a(x);
  assert(a.get_angle() == x);
}

Describe alternatives you've considered

None.

Additional context

None.

DynCoder commented 5 years ago

I don't think this is necessary

Op vr 12 apr. 2019 21:17 schreef Richel Bilderbeek <notifications@github.com

:

Is your feature request related to a problem? Please describe.

A tile has both a coordinate and an angle. Both are doubles, thus easily confused.

Describe the solution you'd like

Make a very simple angle class with a test_angle functions.

void test_angle() { const double x = 123.456; const angle a(x); assert(a.get_angle() == x); }

Describe alternatives you've considered

None.

Additional context

None.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/richelbilderbeek/djog_unos_2018/issues/553, or mute the thread https://github.com/notifications/unsubscribe-auth/Ab-Tkpn3GFesxLGeEBS1GLJxtzLPd1RPks5vgNuugaJpZM4csw8P .

richelbilderbeek commented 5 years ago

Just convinced @Joshua260403 of The Right Thing To Do :rainbow:

martprenger commented 5 years ago

@richelbilderbeek thinks this is beyond the next deadline. Closing ...