richelbilderbeek / djog_unos_2018

Project by the Uno's at DJOG 2018-2019: Nature Zen
GNU General Public License v3.0
6 stars 2 forks source link

Clean up sfml_title_screen::exec #560

Closed richelbilderbeek closed 5 years ago

richelbilderbeek commented 5 years ago

Is your feature request related to a problem? Please describe.

Currently, sfml_title_screen::exec looks like this:

void sfml_title_screen::exec()
{
  //...

    {
      switch (event.type) //!OCLINT TODO too few branches, please fix
      {
        //...
      }
    }

    //m_bg_sprite.setPosition(sf::Vector2f(m_window.getView().getCenter().x -
    //                                     m_bg_sprite.getTexture()->getSize().x,
    //                                     m_window.getView().getCenter().y -
    //                                     m_bg_sprite.getTexture()->getSize().y));

    //...
  }
}

The OCLint tag and the commented code appear to be a left-over from the past.

Describe the solution you'd like

Remove the OCLint tag. Remove the commented code.

All tests should keep passing.

Describe alternatives you've considered

None.

Additional context

None.