search

richelbilderbeek / djog_unos_2018

Project by the Uno's at DJOG 2018-2019: Nature Zen
GNU General Public License v3.0
6 stars 2 forks source link

Remove the confirm_tile_move function from the sfml_game class #574

Closed janderkkotlarski closed 5 years ago

janderkkotlarski commented 5 years ago

An issue of non-functional code, this function does nothing and eats up precious coding space. Delete this function in the cpp and header files of sfml_class.

richelbilderbeek commented 5 years ago

I guess this is just confusion: indeed it has/had no code coverage.

Currently, it is tested and I confirmed (using an assert(1==2);) that the function is actually called.

Thanks @janderkkotlarski for checking, but I hope to have convinced you that the function must remain in, and this Issue can be closed :rainbow:

Stay vigilant :+1: