richelbilderbeek / djog_unos_2018

Project by the Uno's at DJOG 2018-2019: Nature Zen
GNU General Public License v3.0
6 stars 2 forks source link

Disable sound effects by default #586

Closed richelbilderbeek closed 5 years ago

richelbilderbeek commented 5 years ago

Is your feature request related to a problem? Please describe.

We have our first sound effects. Cool!

However, when we work on the game, that should be in silence.

Describe the solution you'd like

Like the music, the sound effects should be off by default. Only if --music is added as a runtime argument should we hear both music and sound.

If you think it'd be better to split sounds and music, add a --sounds as a flag to enable the sounds.

Describe alternatives you've considered

None.

Additional context

Add any other context or screenshots about the feature request here.

rijkvp commented 5 years ago

Travis is fixed but don't merge yet. I am working on something else.