search

richelbilderbeek / pirouette

R package that estimates the error BEAST2 makes from a given phylogeny
GNU General Public License v3.0
3 stars 2 forks source link

Remove geiger #391

Closed Giappo closed 4 years ago

Giappo commented 4 years ago

At the moment on develop branch, there are no calls to geiger functions. However the package is still included in the DESCRIPTION file and loaded in a test. I suggest we remove every occurrance of geiger in pirouette (as it is already on the giovanni branch). If you agree @richelbilderbeek I will proceed.

richelbilderbeek commented 4 years ago

TLDR: already fixed :+1:

I've seen your work in removing geiger. It was well done, so it already reached master.

After that, I found out nodeSub depends on geiger as well, triggering that nasty message, breaking a test. I solved this by adding geiger to the DESCRIPTION, yet in the Suggests section.

But, indeed, you can solve it: just call the function twice!

Blimey, have already fixed this Issue... thanks :+1: