search

richelbilderbeek / pirouette

R package that estimates the error BEAST2 makes from a given phylogeny
GNU General Public License v3.0
3 stars 2 forks source link

'get_pir_params_filenames' does not return all files #395

Closed richelbilderbeek closed 4 years ago

richelbilderbeek commented 4 years ago

Describe the bug

'get_pir_params_filenames' does not return all files.

To Reproduce

pir_params <- create_test_pir_params()

filenames <- get_pir_params_filenames(pir_params)

flat_pir_params <- unlist(pir_params)
filename_indices <- stringr::str_detect(
  string = names(flat_pir_params),
  pattern = "filename"
)
filenames_from_flat_list <- as.character(unlist(flat_pir_params[filename_indices]))

expect_true(all(filenames_from_flat_list %in% filenames))
expect_true(all(filenames %in% filenames_from_flat_list))

Expected behavior

All 11 files should be there.

Environment: Show the results of running the following script:

library(mcbette)
mcbette::mcbette_report()

Another bug: mcbette::mcbette_report() does not work.

richelbilderbeek commented 4 years ago

Fixed!