'get_pir_params_filenames' results differ between 'flat' and 'oldskool'

[richelbilderbeek]

Describe the bug

get_pir_params_filenames returns the names of the files a pir_params will create. There are two methods to do so: oldskool (the older version) and flat (a newer version). These two methods give a different number of files.

To Reproduce

  pir_params <- create_test_pir_params()
  flat_filenames <- get_pir_params_filenames(
    pir_params, method = "flat"
  )
  oldskool_filenames <- get_pir_params_filenames(
    pir_params, method = "oldskool"
  )
  expect_equivalent(flat_filenames, oldskool_filenames)

Expected behavior

Filenames should be the same.

Screenshots

NA

Environment: Show the results of running the following script:

library(mcbette)
mcbette::mcbette_report()

Sure:

> mcbette::mcbette_report()
[1] "****************"
[1] "* Dependencies *"
[1] "****************"
[1] "beautier version: 2.3.4"
[1] "tracerer version: 2.0.4"
[1] "beastier version: 2.1.2"
[1] "mauricer version: 2.0.6"
[1] "babette version: 2.1.2"
[1] "***************"
[1] "* BEAST2      *"
[1] "***************"
[1] "Is BEAST2 installed: TRUE"
[1] "BEAST2 version: 2.6.1"
[1] "BEAST2 default path: /home/richel/.local/share/beast/bin/beast"
[1] "*******************"
[1] "* BEAST2 packages *"
[1] "*******************"
[1] "Is BEAST2 NS package installed: TRUE"
[1] "BEAST2 NS installed version: 1.1.0"
[1] "BEAST2 NS latest version: 1.1.0"
[1] "***************"
[1] "* sessionInfo *"
[1] "***************"
R version 3.6.1 (2019-07-05)
Platform: x86_64-pc-linux-gnu (64-bit)
Running under: Ubuntu 19.10

Matrix products: default
BLAS:   /usr/lib/x86_64-linux-gnu/blas/libblas.so.3.8.0
LAPACK: /usr/lib/x86_64-linux-gnu/lapack/liblapack.so.3.8.0

locale:
 [1] LC_CTYPE=en_US.UTF-8          LC_NUMERIC=C                 
 [3] LC_TIME=en_US.UTF-8           LC_COLLATE=en_US.UTF-8       
 [5] LC_MONETARY=en_US.UTF-8       LC_MESSAGES=en_US.UTF-8      
 [7] LC_PAPER=nl_NL.UTF-8          LC_NAME=nl_NL.UTF-8          
 [9] LC_ADDRESS=nl_NL.UTF-8        LC_TELEPHONE=nl_NL.UTF-8     
[11] LC_MEASUREMENT=en_US.UTF-8    LC_IDENTIFICATION=nl_NL.UTF-8

attached base packages:
[1] stats     graphics  grDevices utils     datasets  methods   base     

loaded via a namespace (and not attached):
 [1] compiler_3.6.1 magrittr_1.5   tools_3.6.1    curl_4.3       rappdirs_0.3.1
 [6] beautier_2.3.4 mcbette_1.8.2  mauricer_2.0.6 stringi_1.4.6  beastier_2.1.2
[11] stringr_1.4.0  testit_0.11    rJava_0.9-11  

Additional context

For candidate models the functions are equal, so I predict it is only the evidence file that flat does return, where oldskool does not