search

richelbilderbeek / pirouette_article

Article about pirouette, by Bilderbeek, Laudanno and Etienne
GNU General Public License v3.0
0 stars 0 forks source link

Separate final plot #48

Closed richelbilderbeek closed 5 years ago

richelbilderbeek commented 5 years ago

From:

2019-05-16-100012_1920x1056_scrot

Modify the code in scripts/example3.R to satisfy the feedback.

Current code is:

pir_plot(errors) +
  ggsave(file.path(example_folder, "errors.png"))
richelbilderbeek commented 5 years ago

I think something like:

pir_plot(
  get_pir_run_test_output(TRUE, TRUE)
) + ggplot::facet_plot(model_type = "generative" ~ .)

will help discover how to do this.

Giappo commented 5 years ago

Glad you approve my idea. Unfortunately I don't have the time to fix that in the next 7 days. In case it will be not ready at that time I'll fix it myself.

richelbilderbeek commented 5 years ago

Current plots look pretty, thanks to @Giappo. Done!