Fix build error - Githubissues

richelbilderbeek / raket

What is the error we make, when nature has protracted speciation, and inference ignore this?

GNU General Public License v3.0

0 stars 0 forks source link

Fix build error #15

Closed richelbilderbeek closed 6 years ago

richelbilderbeek commented 6 years ago

Since this commit the build is broken.

H0: it is lack of Roxygen2: REJECTED H1: it is upstream: start test

richelbilderbeek commented 6 years ago

If H1 ('it is upstream') is true, a trigger of this build will cause the clean build to fail

before

richelbilderbeek commented 6 years ago

It is upstream:

after

J-Damhuis commented 6 years ago

I assume there is nothing we can do then?

richelbilderbeek commented 6 years ago

It means that

all of us (@Tomdkkr) need to check our code locally (using 'Check') before pushing
I will Google and fix it. You may volunteer to Google along, if and only if there is time
If upstream works again, we'll have to mend the pieces together again

richelbilderbeek commented 6 years ago

Hmmm, that now-failing-build has a different error message.

Will reset caching in .travis.yml

richelbilderbeek commented 6 years ago

No need to reset cache: AppVeyor fails as well.

Did something bold instead: merge everything with master. :rainbow_flag: not exactly wise :rainbow_flag:.

richelbilderbeek commented 6 years ago

Packages that join the crashing mood:

beastier

richelbilderbeek commented 6 years ago

Ah, it is a known Issue that is worked on

richelbilderbeek commented 6 years ago

OK, the build error appears fixed.

New error:

Quitting from lines 96-101 (demo.Rmd) 
Error: processing vignette 'demo.Rmd' failed with diagnostics:
attempt to set an attribute on NULL
Execution halted

richelbilderbeek commented 6 years ago

Fixed that error with a workaround, error is in rkt_plot being called in the demo vignette.

richelbilderbeek commented 6 years ago

@J-Damhuis or @Tomdkkr:if the lintr-bot errors annoy you, feel encouraged to clean them up (of course: we should usually clean up our own mess). I will do so myself after submitting my babette article as a Microsoft Word :sob: document, as that has absolute priority.