Edit registration - Githubissues

richeterre / jumubase

A friendly monolith for managing "Jugend musiziert" contests ♫

MIT License

3 stars 0 forks source link

Edit registration #4

Closed richeterre closed 5 years ago

richeterre commented 5 years ago

This lets users edit their existing registration via an edit code (shown to organizers on the performance detail page).

[x] Add appearance or piece
[x] Remove appearance or piece
[x] Modify appearance info (except participant name + birthdate)
[x] Modify piece info
[x] Update performance and appearance age groups
[x] Handle validation errors
[x] Handle empty appearances and/or pieces upon submission

richeterre commented 5 years ago

@denisw I figured out the birthdate problem btw – the changeset format is 2005-01-02 whereas the params look like this: { day: "2", month: "1", year: "2005" }. So probably something we can quite easily handle during param flattening. I'm just not sure how to do this cleanly without a dedicated date library…

PS: I also pushed a fix to the seed file, so seeding should work again!

richeterre commented 5 years ago

Alright, this is ready to merge if you approve ☺️

denisw commented 5 years ago

It's quite a lot of code, but what I looked at looks good and it also works well when testing. Approved. 👍