search

richfaces / richfaces-sandbox

Sandbox repository for Component Incubation
http://community.jboss.org/wiki/RichFaces40ComponentDevelopmentProcess
76 stars 101 forks source link

Radio component + panel fix #14

Closed blabno closed 12 years ago

lfryc commented 12 years ago

I'm okay with merging first two commits, but I hesitate to merge the last one (jrebel settings).

lfryc commented 12 years ago

It is good practice to push unrelated change sets to several pull requests. It allows to deal with potentional issues straight-forward.

blabno commented 12 years ago

Lukas, I've think that single rebel.xml is enough. And it's better this way cause there is no guarantee that demo is not packaged with ui snapshot from remote repo without rebel.xml.

As to multiple pull requests, Doesn't it force me to create separate branches for each request?

lfryc commented 12 years ago

Hi Bernard, it's better to pull separately, and develop on feature branches: https://community.jboss.org/wiki/RichFacesGitWorkflowModel

But I will merge your first two commits.

The jrebel commit needs to be refined - plugin versions should be moved to pluginManagement section somewhere in the parent structure.

I agree with you that it is simpler to have just one rebel.xml in demo, but it's not clean way.

With rebel-plugin configuration in demo and UI, you need just execute mvn package -Pjrebel on their parent.

lfryc commented 12 years ago

Hi Bernard, I have changed the jrebel profiles accordingly.

The version for jrebel plugin was moved to richfaces-root-parent.

Thanks for the pull request!

~ Lukas