Closed pauldijou closed 12 years ago
RichFaces » sandbox #33 FAILURE Looks like there's a problem with this pull request (what's this?)
I realise I missed the discussion, but why the rename of header/footer to headerGroup/footerGroup? menuGroup is a group of links, but header is just a header...
Because there are real tags "header" and "footer" on HTML5. So "b:header" and "b:footer" should be related to those tags. So we renamed to "...Group" all stuff related to components without renderer by default but which will get one from their parent.
The discussion was lead here: http://transcripts.jboss.org/meeting/irc.freenode.org/richfaces/2012/richfaces.2012-06-26-14.09.log.html
14:52:13
As there are concerns about conflicting names b:header
tag and header
as HTML5 semantic component,
I don't think there will be specialized h:header
tag for rendering header
in JSF.
When I see how badly HTML components are handle in a JSF view, I think that every HTML tag should have a JSF equivalent. (for example, having five "a" tags will result on only one JSF component wrapping them all, enjoy that when rendering a navbar who need to wrap each of its children inside a "li")
So "b:header" should be the JSF component to render "header" HTML tag in my opinion. And we can name all our semantic components with the following syntax "functionnalityGroup" (like "headerGroup" or "menuGroup"). The "Group" term is only because of the 1st idea of grouping a few weeks ago. Any other name is fine with me, but I would still keep a suffix that indicates it's not directly a real component but just a semantic purpose (nearly like a facet but not exactly).
Accepting this pull request as is for now - however we will do a further refactoring from Group to Facet, looking for a more meaningful naming convention.
RichFaces » sandbox #54 SUCCESS This pull request looks good (what's this?)