search

richfaces / richfaces-sandbox

Sandbox repository for Component Incubation
http://community.jboss.org/wiki/RichFaces40ComponentDevelopmentProcess
76 stars 101 forks source link

add breadcrumb support #51

Closed dgouyette closed 12 years ago

dgouyette commented 12 years ago

I add the breadcrumb support. Just a question, for the demo part,which app server do you use ?

buildhive commented 12 years ago

RichFaces » sandbox #187 SUCCESS This pull request looks good (what's this?)

lfryc commented 12 years ago

Hey Damien,

this is cool, thanks for great addition.

We are mostly using JBoss AS 7.1 but it should work on each Java EE 6 compliant application server. If it doesn't work, we should fix that! :-)

One comment, could you please to add JIRA identifier to the commit message (RFSBOX-18)? It helps us to pair commits with JIRA issues. https://issues.jboss.org/browse/RFSBOX-18

You can change current commit and "force" push to same branch:

git commit --amend git push origin develop -f

lfryc commented 12 years ago

Could you also, by any chance, add sample of usage to bootstrap-demo?

https://github.com/richfaces/sandbox/tree/develop/bootstrap/demo/src/main/webapp/component

dgouyette commented 12 years ago

Ok, thanks for your answer. I will amend my commit with issue number and the demo part.

lfryc commented 12 years ago

Awesome, thanks Damien!

buildhive commented 12 years ago

RichFaces » sandbox #195 SUCCESS This pull request looks good (what's this?)

dgouyette commented 12 years ago

I amend my commit and added demo part. But commit ead5c12 is not expected and contain nothing. I don't know git very well... Is it annoying ?

lfryc commented 12 years ago

Hey Damiene, no problem, I have dealt with it. :-)

Merged and published to the online demo: https://twitter.com/lfryc/status/255250928796573696

Great job!