richfaces / richfaces-sandbox

Sandbox repository for Component Incubation
http://community.jboss.org/wiki/RichFaces40ComponentDevelopmentProcess
76 stars 101 forks source link

add captcha component #60

Closed dejewi closed 11 years ago

buildhive commented 11 years ago

RichFaces » sandbox #361 SUCCESS This pull request looks good (what's this?)

lfryc commented 11 years ago

Hey, Krzysztof, thanks for the great addition.

Could you please make sure to sign Contributor License Agreement on https://cla.jboss.org/index.seam ?

lfryc commented 11 years ago

Krzysztof, could you please also make sure to open relevant issue in issue tracker [1]?

Btw there is a small overview of the contribution process [2].

[1] https://issues.jboss.org/browse/RFSBOX [2] https://github.com/richfaces/sandbox/blob/develop/CONTRIBUTING.md

dejewi commented 11 years ago

Hi Lukas, I have just signed CLA. Opened issue in issue tracker is RFSBOX-104.

bleathem commented 11 years ago

Confirmed, Krzysztof Miksa has signed the CLA.

Thanks for taking the time to contribute this component Krzysztof! We'll review the component and establish any additional criteria that need to be met to include this component in a future release of RichFaces.

buildhive commented 11 years ago

RichFaces » sandbox #368 SUCCESS This pull request looks good (what's this?)

lfryc commented 11 years ago

Hey Krzysztof, great contribution, thanks!

Could you please improve two things?

lfryc commented 11 years ago

Could you please also update to 4.3.1-SNAPSHOT?

dejewi commented 11 years ago

Ok, thanks :) I will make changes for Tuesday.

lfryc commented 11 years ago

Hey Krzysztof, this would be great contribution to RichFaces. Any chance you could improve the code so we could merge it?

Thanks, ~Lukas

dejewi commented 11 years ago

Sorry Lukas, I have no time last time. I promise to complete this during this weekend.

lfryc commented 11 years ago

It would be great!