The chart component

[lfryc]

Generally component class Javadoc should be improved to describe carefully what is intension of the tag, which tags it suppose to be combined with. (E.g. You can see See <x:xaxis />, etc.)

https://github.com/Lukindo/richfaces-sandbox/blob/master/charts/ui/src/main/java/org/richfaces/sandbox/chart/component/AbstractChart.java#L23

Attributes (method) javadoc should be described more verbosely to express their purpose.

• where will the title appear? https://github.com/Lukindo/richfaces-sandbox/blob/master/charts/ui/src/main/java/org/richfaces/sandbox/chart/component/AbstractChart.java#L38
• what is zoom about? https://github.com/Lukindo/richfaces-sandbox/blob/master/charts/ui/src/main/java/org/richfaces/sandbox/chart/component/AbstractChart.java#L48

Generally one should know what he can expect by using given attribute before he even try.

[lfryc]

Okay, otherwise it's good to go. :+1:

I can't wait to play with it and provide you with little bit more feedback on usability side of things!

[lmacko]

• I've changed template document.getElementById and I've add java doc comments to attributes.
• Title is currently show above the chart. It requires some css styles I'll add it later
• I've also update examples

[bleathem]

I've merged the pull request https://github.com/richfaces/richfaces/pull/46 which was blocking this PR.

[bleathem]

We still have a upstream richwidgets problem with the included version of the flot library: https://github.com/richwidgets/richwidgets/issues/20

While not necessarily blocking the Pull Request, we should get it resolved before asking folks to take this component for a test spin.

[lmacko]

I've sent pull request fixing the issue.

[lfryc]

Merged into master.

Great job, Lukas!