search

richfelker / musl-cross-make

Simple makefile-based build for musl cross compiler
MIT License
1.31k stars 266 forks source link

GCC 11.4.0 fails to build #189

Open krant opened 6 months ago

krant commented 6 months ago

TARGET is aarch64-linux-musl, 11.2.0 builds all right. Host is Arch Linux with GCC 14.

../../src_gcc/libiberty/simple-object-mach-o.c: In function ‘simple_object_mach_o_write_segment’:
../../src_gcc/libiberty/simple-object-mach-o.c:1231:17: error: passing argument 1 of ‘set_32’ from incompatible pointer type [-Wincompatible-pointer-types]
 1231 |         set_32 (&index[i], index[i]);
      |                 ^~~~~~~~~
      |                 |
      |                 unsigned int *
../../src_gcc/libiberty/simple-object-mach-o.c:1231:17: note: expected ‘unsigned char *’ but argument is of type ‘unsigned int *’
rofl0r commented 6 months ago

does this patch fix the issue ? https://gcc.gnu.org/git/?p=gcc.git;a=blobdiff;f=libiberty/simple-object-mach-o.c;h=a8869e7c63957d86d91d9987bbed40c8284fd253;hp=72b69d19c21627aa29347bc3798aa8f407965fc7;hb=38757aa88735ab2e511bc428e2407a5a5e9fa0be;hpb=6a64964212c8e5e10e474803d06a07514c1069b7

krant commented 6 months ago

It does indeed, thank you! I've pushed a PR - #190

mwetterw commented 1 week ago

The issue not only happens on aarch64, but also on arm.

I tested both:

The PR is fixing both issues at once! I would really like to see this patch merged.