richfitz / diversitree

diversitree: comparative phylogenetic analyses of diversification
http://www.zoology.ubc.ca/prog/diversitree
30 stars 9 forks source link

Bug in info of musse #27

Open KYPpa opened 3 years ago

KYPpa commented 3 years ago

Edit of the argnames of musse objects fails like below.

argnames(lik)[1]<-c("l") Error in argnames<-.dtlik(*tmp*, value = c("l", "lambda2", "lambda3", : Wrong argnames length: expected 15, got 12

Then I checked the source and found in "model-musse.R"

make.info.musse <- function(k, phy) { list(name="musse", # canonical name (as in make.) name.pretty="MuSSE", # pretty name for printing

Parameters:

   np=as.integer(k * (k + 2)), # number of ODE parameters

The parameters should be composed of k lambda, k mu and k(k-1) transition rates. Then np=as.integer(k (k + 1)) seems to be correct.