search

richfitz / drat.builder

Build tools for a drat
Other
17 stars 2 forks source link

fancy new r/travis looks not to be working: #10

Closed richfitz closed 9 years ago

richfitz commented 9 years ago

https://travis-ci.org/richfitz/drat.builder

richfitz commented 9 years ago

nope, apparently still not working...

cboettig commented 9 years ago

seems to be working now

richfitz commented 9 years ago

There's a test error (line 823) but that doesn't trigger a failure.

cboettig commented 9 years ago

at least travis seems to be counting this as a real error for me now: https://travis-ci.org/richfitz/drat.builder/builds/72649857

richfitz commented 9 years ago

Will look into this shortly, but I'm moving country in 2 days so it might take a little while!

That error looks like there's a few weird things going on there. I'll take a look. In particular, I think I've seen:

make test
... test failure ...
The command "make test" exited with 0.

before, as I don't think testthat is really meant to be driven the way I like to drive tests.

The only reason that build fails is because of a documentation warning caught by "warnings are errors".

richfitz commented 9 years ago

Fixed in 786a505

richfitz commented 9 years ago

Nope, despite working locally, this still fails. I think that the issue is that there are two failure modes in testthat (errors and fails) and I need to test for both...

richfitz commented 9 years ago

OK, I think that's fixed. It's a little complicated with the apparent failure in the travis logs because that's not a fatal error by design...