search

richfitz / drat.builder

Build tools for a drat
Other
17 stars 2 forks source link

permit defaults for no-build-vignettes and no-manual to be configured #11

Closed cboettig closed 9 years ago

cboettig commented 9 years ago

This just adds a command line option and propagates it through which allows the defaults to be configured for turning off building manual and vignettes.

I left the default configuration the way you had it (no manual, yes vignettes), but I think (no, no) is a better default (e.g. matches what install_github defaults to). It doesn't make sense that install defaults to false but vignettes defaults to true, since in general we cannot assume we can build the vignette without install the suggested packages. More generally, building vignettes can be very slow, and just adds another point of failure. install_github has already trodden this path, and revoked the building of vignettes and installing of suggested packages by default, so we can learn from history here.

cboettig commented 9 years ago

@richfitz any thoughts?

richfitz commented 9 years ago

Ah, thanks for tagging me. For some reason I don't see PR notifications on email so I totally missed this. I have no strong feelings about the default arguments here, so go ahead and change them to what you think is best.

If you do that, do you have strong feelings about :gb: English (s/behavior/behaviour/g)?

cboettig commented 9 years ago

@richfitz cool, default and spelling fixed. will leave it to you to merge

cboettig commented 9 years ago

@richfitz ping -- okay to merge this? (Just noticed I'm still building ropensci drat against my branch since it has this)

richfitz commented 9 years ago

Thanks for the reminder - I'll try and get on this next week perhaps.

richfitz commented 9 years ago

OK, working on this now. There are two issues here - one is that the docs were out of sync; that one is easy to fix (f21196a). The other issue is that travis and I are getting git2r errors on the rrdf package, which I'll fix as part of #8.