search

richfitz / drat.builder

Build tools for a drat
Other
17 stars 2 forks source link

multiple packages in same repo #13

Open cboettig opened 9 years ago

cboettig commented 9 years ago

It looks like drat.builder now supports the package root not being in the git root directory, but it still complains if two packages are in the same repo (which in my experience is the main reason someone uses this pattern in the first place), e.g.

egonw/rrdf/rrdflibs
egonw/rrdf/rrdf

I realize the logic is a bit tricky here, since drat.builder doesn't want to attempt to clone the repo twice..

richfitz commented 9 years ago

Cool, I'll get onto it.

On the other hand - it's a real shame that rrdf has to do things so differently to basically every other package.

cboettig commented 9 years ago

Hmm, I still seem to be hitting this same error, e.g. here: https://circleci.com/gh/ropensci/drat/91?utm_campaign=build-failed&utm_medium=email&utm_source=notification

yeah, it's a shame people do this; I think CRAN is to blame for making people use a second "lib" package when you have a package that ships with a large set of code in some other language that is not likely to change as much. I can see why someone would still want to use the same repo for both packages.