add 4.1 path - Githubissues

nbenn commented 3 years ago

I'm happy to add to this PR, to make this automatic, e.g. by pulling in versions using r-hub/rversions. What do you think?

richfitz commented 3 years ago

Thanks @nbenn! The place to make it automatic would be in drat.builder (https://github.com/richfitz/drat.builder) which I'll do now. We could hit r-hub for this, though it changes much less frequently than we update the repo. Hopefully by the time that 4.2 has come out we'll be fully transitioned to r-universe (https://mrc-ide.r-universe.dev/ui#packages)

richfitz commented 3 years ago

Sorry I totally misread the repo that this was in :facepalm:

Thanks again!

nbenn commented 3 years ago

While you're at it, somewhere around https://github.com/richfitz/drat.builder/blob/713d087610c3b5a9e0465db80721ddf6cf839268/R/drat_builder.R#L390 utils::contrib.url() might be of use for path construction? Also, for macOS, not all combinations of "type" and version might be required (at least this is the case on CRAN). From what I saw, it goes something like

mac.binary.mavericks: 3.2 through 3.3
mac.binary.el-capitan: 3.4 through 3.6
mac.binary: 4.0 and onwards

Just fyi, it also works fine the way it is currently.

richfitz / drat.builder

add 4.1 path #23