search

richfitz / redux

:telephone_receiver::computer: Redis client for R
https://richfitz.github.io/redux
89 stars 17 forks source link

SSL support #27

Open jcohen02 opened 5 years ago

jcohen02 commented 5 years ago

Hi, With the recent merging of SSL support into master in hiredis (https://github.com/redis/hiredis/pull/645), it would be great to have the ability to make secure connections to redis via redux.

An initial implementation of this is available in jcohen02/redux@1c0232b784bb25b18069bc487395ac3be5c7f9df but I wanted to get thoughts on this prior to submitting a PR - I'm assuming this will require a modified version of hiredis to be made available in rwinlib/hiredis but I wasn't clear at this stage whether it might present other cross-platform/dependency issues.

EnvisionRisk commented 3 years ago

Hi @richfitz, Is SSL support a feature that will be available in the redux package?
Best wishes Jonas

jcohen02 commented 3 years ago

@richfitz, @jeroen the feature/ssl branch in my fork has now been updated to use the modified API in hiredis 1.0.0.

I've updated tools/winlibs.R to pull hiredis-1.0.0 from rwinlib/hiredis and updated Makevars.win to add the necessary libraries for building with SSL support.

I had some issues on Mac OS since I was building using my own build of hiredis-1.0.0 and avoiding the brew-based scripts, this may need some further checking along with Linux builds.

Should we be looking to build with SSL support by default or is there some way to pass an option via install.packages or similar to specify whether or not to install redux with SSL support - is this necessary.

Once I've completed some further testing, I'll open a PR in preparation for getting this merged into the main repo.

Thanks.