search

richfitz / redux

:telephone_receiver::computer: Redis client for R
https://richfitz.github.io/redux
91 stars 17 forks source link

Windows: update to hiredis 1.0.0 #35

Closed jeroen closed 4 years ago

jeroen commented 4 years ago

This is a prerequisite for a user that is working on SSL support.

Also, the chocolately redis-64 package seems to be deprecated, and is now a virtual package that installs another one. From the description:

The MS Open Tech Redis on Windows was frozen at version 3.x when it was archived few years ago. Since that time there were a few new major releases of Redis on Linux. Reading the release notes for Redis 4.x and Redis 5.x, one can see that there are several security vulnerabilities that were fixed since. The current package might pose risk to systems and it is better to retire it. As an alternative to the old package we recommend using Memurai which is on par with Redis 5.x and has the known security vulnerabilities addressed.

jeroen commented 4 years ago

OK, the changes in this PR are Windows only, so unrelated to Travis (the appveyor build passes). So I think you can go ahead and merge this to unblock Jeremy.

richfitz commented 4 years ago

This has been cherry-picked into #38, thanks @jeroen