richfitz / remake

Make-like declarative workflows in R
Other
340 stars 32 forks source link

Bindings created by create_bindings() should never make #144

Closed krlmlr closed 7 years ago

krlmlr commented 7 years ago

only fetch. Calling make() in an active binding can be very disruptive, especially in an IDE that starts querying these bindings when I edit source files that alter the value of a binding. Creating bindings will then be a faster version of dump_environment(), we might get rid of the latter then (unless there's a use case I haven't considered).

richfitz commented 7 years ago

Ouch, sounds bad.

I like dump_environment() because it's easier to wrap my head around and provides an escape-hatch of sorts.

krlmlr commented 7 years ago

I don't understand the check for obj$config$active in active_bindings.R, though. Can we just ignore that value and simply fetch?

richfitz commented 7 years ago

There may have been a disable/enable switch at some point, probably related to the interactive remake experimentation. It can just be removed