Download command fails on (some) windows machines

richfitz / remake

Make-like declarative workflows in R

Other

340 stars 32 forks source link

Download command fails on (some) windows machines #71

Open dfalster opened 8 years ago

dfalster commented 8 years ago

Hi Rich,

In prepping for a tutorial on remake (https://github.com/traitecoevo/remake_baad_example), @johnbaums discovered that the download rule in remake was not working quite correctly on his windows machines. The issue was described here. A temporary workaround was to replace the inbuilt download command from remake with a function which explicitly declares mode ="wb", as implemented here.

Looking at remake's implementation the mode argument is missing.

dfalster commented 8 years ago

Ah, just saw this https://github.com/richfitz/remake/pull/65

richfitz commented 8 years ago

So, R's internal download support seems to be in a state of flux at the moment. I might try and swap the current system out for libcurl based downloads, or move to the approach in dataverse (using the curl package). Thanks for the reminder about #65. I am hoping to do a remake push once I get the storr bits done soon.