Failing test on R-3.2.0 (RHEL 7)

richfitz / storr

:package: Object cacher for R

http://richfitz.github.io/storr

Other

117 stars 10 forks source link

Failing test on R-3.2.0 (RHEL 7) #101

Closed wlandau closed 5 years ago

wlandau commented 5 years ago

test-hash.R:6: failure: serialize, dropping R version
identical(s1, s2) isn't false.

Fails on R-3.2.0 with 27508231b3c061afed9bb243d4422f81291f2e94 and 80f33d9458cab7aa40aaf31cbbd52f40d1659117. Succeeds on R-3.3.0. I have not looked at the details yet.

wlandau commented 5 years ago

This is the part that fails on R-3.2.0:

s1 <- make_serialize_object(FALSE, FALSE)(NULL) # no drop, binary
s2 <- make_serialize_object(TRUE,  FALSE)(NULL) #    drop, binary
expect_false(identical(s1, s2))

Apparently, serialize_to_raw() and serialize_drop_r_version() are supposed to return different values here. Would it be appropriate to just require R >= 3.3.0 here? Except for ALTREP, I have not been tracking changes to serialization in R.

richfitz commented 5 years ago

Obsolete by #98 as we depend on 3.3.0 now