Don't use start_end_reporter argument in testthat 3.0.0

richfitz / storr

:package: Object cacher for R

http://richfitz.github.io/storr

Other

116 stars 10 forks source link

Don't use start_end_reporter argument in testthat 3.0.0 #124

Closed hadley closed 4 years ago

hadley commented 4 years ago

This is technically a breaking change in testthat, but so few packages (i.e. just storrr out of ~3000 packages tested so far), I'd prefer to just break the API if you don't mind accepting this PR.

richfitz commented 4 years ago

Thanks Hadley, no problem accepting this (I'll fix the postgres-related travis failure elsewhere). What is your timeline for the CRAN release of testthat?

hadley commented 4 years ago

All going well, I'll formally start the release process on Friday, so that means at its at least 4 + 30 days away.