search

richfitz / wood

How much of the world is woody?
http://richfitz.github.io/wood
Other
20 stars 9 forks source link

Do not use init file in Rscript commands #18

Open fleimgruber opened 10 years ago

fleimgruber commented 10 years ago

This is so that settings in init files, e.g. locale settings or options() calls do not garble Rscript return values

richfitz commented 10 years ago

Thanks for this! Rscript never manages to cause random headaches, and that one (output emitted from init files) has messed up package compilation before.

Unfortunately it looks like that messes up packrat: https://travis-ci.org/richfitz/wood/jobs/27453198#L1601-L1604

Perhaps --no-user-file is more appropriate here? That might still run into the same problem.

fleimgruber commented 10 years ago

Yeah, just saw the Travis CI log. From first sight it looks like sowsear lib is used before being correctly installed. I just toyed with packrat before, no clue why that's messing it up - it definitely should not. I do not have time to look into --no-user-file right now, but as you said, I would assume this to fail similarly. Will check back after more testing (time).

fleimgruber commented 10 years ago

Finally found the time to try it out once more. It turns out your hunch was correct. Good to merge?