richgel999 / jpeg-compressor

C++ JPEG compression/fuzzed low-RAM JPEG decompression codec with Public Domain or Apache 2.0 license
210 stars 57 forks source link

Decoder RGB scanline coping type #5

Closed GoogleCodeExporter closed 4 years ago

GoogleCodeExporter commented 9 years ago

jpgd.cpp, line 3101 should be:
if (((req_comps == 1) && (decoder.get_num_components() == 1)) || ((req_comps == 
3) && (decoder.get_num_components() == 3)))

Original issue reported on code.google.com by pixst...@gmx.net on 13 Mar 2014 at 7:25

GoogleCodeExporter commented 9 years ago
[deleted comment]
GoogleCodeExporter commented 9 years ago
This is wrong suggestion.

Original comment by mrpuzz...@gmail.com on 21 May 2014 at 9:12

richgel999 commented 4 years ago

The original code is correct because on RGB images the jpeg_decompressor class returns 4 bytes/pixel:

if (((req_comps == 1) && (decoder.get_num_components() == 1)) || ((req_comps == 4) && (decoder.get_num_components() == 3)))