search

richgel999 / lzham_codec

Lossless data compression codec with LZMA-like ratios but 1.5x-8x faster decompression speed, C/C++
Other
693 stars 71 forks source link

modification for compatibility (AIX, Android NDK), for smartversion compile #27

Open gvollant opened 3 years ago

gvollant commented 3 years ago

some compatibility patch are from previous pull request

Pull requet #25 was accidentelly closed, so I reopen this PR

gvollant commented 3 years ago

@janisozaur @richgel999 can you look at #27

gvollant commented 3 years ago

@richgel999 I made a minor update to compile on macos 11 on arm64

I'll be happy if you take a look !

gvollant commented 3 years ago

@janisozaur you can also look

janisozaur commented 3 years ago

My objection regarding improper commit message still stands

janisozaur commented 3 years ago 
modification for compatibility for smartversion compile (including android), some compatibility patch are from previous pull request

is not something I would ever want to see as a commit. It does not explain what the "modification for compatibility" is; "modification", as in "code change" is already implied; the "previous pull request" doesn't refer to anything in particular.

The subject line should be glanceable and short, written in imperative mode and above all, should actually explain what it does.

E.g.:

Improve Android support

or

Extend Android support with better memory allocation

or something in that vein