search

richhollis / swagger-docs

Generates swagger-ui json files for Rails APIs with a simple DSL.
MIT License
749 stars 150 forks source link

fix generator for swagger_model when no property required #146

Open FLemon opened 8 years ago

FLemon commented 8 years ago

Before the fix, the generator is assigning null to required field, which raises error

swagger-ui.js:2362 Uncaught TypeError: Swagger 2.0 does not support null types ([object Object]).  See https://github.com/swagger-api/swagger-spec/issues/229.

This fix will instead not to create a required field for the json, as to match the way how swagger_ui has done it, see https://github.com/swagger-api/swagger-ui/blob/master/test/specs/v1.2/petstore/store.json#L113

FLemon commented 8 years ago

@richhollis can you have a look at this PR fix please :)

FLemon commented 7 years ago

@richhollis just to follow up this PR, I am keen to know if the fix is not appropriate, is there something i missed, looking forward to hear from you about your thoughts, thank you

FLemon commented 7 years ago

hello @richhollis , just to follow up this PR, is this something else you would want to check/done with this PR?

FLemon commented 6 years ago

@richhollis ^...wondering if this PR still valid?