richie5um / vscode-sort-json

VSCode Extension to Sort JSON objects
https://marketplace.visualstudio.com/items?itemName=richie5um2.vscode-sort-json
MIT License
110 stars 19 forks source link

errors when enabled together with other extension #52

Open DaWolfi opened 3 years ago

DaWolfi commented 3 years ago

Hi, thanks for your very useful extension! But I noticed a strange behaviour when enabled together with the extension "Here Unicode Mate", which displays the Unicode number of the char behind the cursor in the status line. A piece of code from the file "lodash-sortkeys.js" from your extension is displayed instead of the number, at least when a json file is opened in the editor. And when the command, that ist triggered by a clicking the number, displays a list of different encodings for the char, some entries are also containing pieces of your code: image image

richie5um commented 3 years ago

How strange; I get the same. I'll take a look at the code for that extension and try and work out why.

aolszowka commented 1 year ago

Thank you for this extension, it is very useful, however I wanted to add additional information to this bug report:

This appears to break the ARMView extension (bencoleman.armview) as well (See https://github.com/benc-uk/armview-vscode/issues/54). I was able to identify this by performing an Extension Bisect and ruled this in as the culprit.

The behavior is the same (adding // Shortcut helper to move item to end of array) as seen in the screenshot.

For now, I have disabled this extension.

You can reproduce the issue following the steps in the linked bug report.

richie5um commented 1 year ago

Thanks. I've been incredibly busy with my work for a while. Hopefully I'll get some time to look at this. It was non-obvious last time I had a chance to look.

aolszowka commented 1 year ago

Thanks. I've been incredibly busy with my work for a while. Hopefully I'll get some time to look at this. It was non-obvious last time I had a chance to look.

No worries, open source is a labor of love, and I appreciate your extension. If people want it fixed the code is there for them to provide a patch ;)

If you need any help repro'ing or testing a fix I'm willing to volunteer, that was a tricky one to track down!