search

richinsley / comfy2go

A Go-based API that acts as a bridge to the ComfyUI backend
MIT License
49 stars 13 forks source link

Returning data with SVD ComfyUI Nodes #3

Closed dreamfast closed 8 months ago

dreamfast commented 9 months ago

Hi there, thanks for this great plugin.

With the release of SDV ComfyUI has new node types and file formats to consider. I am not the best Go coder, but will try make a PR to allow for this.

For now it seems with this package it only considers images.

A format like mp4 or webp will return the following error: Deserializing Status Message: json: cannot unmarshal bool into Go struct field .output of type client.DataOutputImages

txt2video_1_2.json - this is the workflow used, originally found on CivitAI. Just recently StabilityAI released version 1.1 of SDV, so that is the model I am using.

dreamfast commented 9 months ago

Trying to output an actual video file, that is not webp format will return Error loading graph JSON: json: cannot unmarshal object into Go struct field GraphNode.nodes.widgets_values of type []interface {}

richinsley commented 8 months ago

I'm looking into this now. It looks like the widget properties for the VHS_VideoCombine is defined as a map of properties instead of an array. I'm not sure if this is a one-off custom implementation by the author or if this is a new style of node serialization defined in ComfyUI.

richinsley commented 8 months ago

In v0.4.0, DataOutputImages is changed to DataOutput, which has a dictionary of the output types instead of just the 'images'