search

richjyoung / vscode-modern-vhdl

Modern VSCode VHDL Support
MIT License
30 stars 12 forks source link

A few more enhancements #18

Closed DanChianucci closed 5 years ago

DanChianucci commented 5 years ago

Basic Grammar Cleanup Added Indentation rules

richjyoung commented 5 years ago

With regard to the grammar namespace changes, can you attach a before/after picture to show the change this makes to some example code? Without seeing the motivation behind it, it's tricky to second guess.

The indent rules look fine for now, longer term I'd expect the indent to increase for any unterminated statement and decrease accordingly. Either way the behaviour for the cases you have highlighted looks unlikely to change once this is done.

DanChianucci commented 5 years ago

That all being said, how it affects the presentation is completely dependant on the theme being used. For me it allows the => and the constants to be highlighted.

richjyoung commented 5 years ago

I seem to remember I referred more to other grammars around the time I was trying to work out the appropriate mapping, however that could have been due to the theme I was using, as it definitely was not a standard one. Will merge this and push a version to the marketplace.