richjyoung / vscode-modern-vhdl

Modern VSCode VHDL Support
MIT License
30 stars 12 forks source link

[Bug] Character literals are not valid enumeration literals #26

Closed pvanschendel closed 4 years ago

pvanschendel commented 4 years ago

bug_problems_with_character_literals_in_enumeration

Again, the github grammar is not much better here, although it is less visible due to the poor contrast (look closely at the 'Y'):

architecture arch of test is
    -- Suggestion: format all literals the same, independent
    -- where they occur.
    type my_logic is (
        '0',
        'x',
        'Y',
        'Z',
        fuzzy_state);

    constant my_logic_constant : my_logic := 'Z';
    constant my_fuzzy_logic_constant : my_logic := fuzzy_state;
begin
end arch;
richjyoung commented 4 years ago

Agreed, and with the changes I recommend on #27, the char literals in the enum will be orange, and the fuzzy_state will stay green.