richliao / textClassifier

Text classifier for Hierarchical Attention Networks for Document Classification
Apache License 2.0
1.07k stars 379 forks source link

Non-exact Implementation of CNN Sentence Classifier #25

Open iamkissg opened 6 years ago

iamkissg commented 6 years ago

Hi Richard,

I just read the paper "Convolutional Neural Networks for Sentence Classification" and your blog as well as code.

It seems that your implementation is not the network described in the paper. According to the paper, the convolution layers are parallel. However, they are serial in your implementation.

You may re-implement you network to see which one achieves better performance.

richliao commented 6 years ago

The final concatenation that merges different windows is what you referred to as parallel. That is what I have implemented.