Changed https to http (Minor docs fix)

richnologies / ngx-stripe

Angular 6+ wrapper for StripeJS

MIT License

219 stars 77 forks source link

Closed AndrewSithole closed 1 year ago

AndrewSithole commented 1 year ago

Changed https to http to match whats defined in the constructor

What are you adding/fixing?

Correcting the example in the docs on this page: https://ngx-stripe.dev/docs/checkout

Have you added tests for your changes?

No. Its an example in the docs

Will this need documentation changes?

No.

Does this introduce a breaking change?

No.

netlify[bot] commented 1 year ago

Name	Link
Latest commit	07a494c307ca4ccd34c05117c2269ea22a128983
Latest deploy log	https://app.netlify.com/sites/ngx-stripe/deploys/638086bc46421d000bc30247
Deploy Preview	https://deploy-preview-189--ngx-stripe.netlify.app/
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

richnologies commented 1 year ago

HI @AndrewSithole,

Thank you very much for you PR; but I think the change is not necessary. The value in the constructor is http too.

AndrewSithole commented 1 year ago

HI @AndrewSithole,

Thank you very much for you PR; but I think the change is not necessary. The value in the constructor is http too.

Cool. I think the file was changed. Great either way.

Thanks for checking my PR.