search

richnologies / ngx-stripe

Angular 6+ wrapper for StripeJS
MIT License
221 stars 75 forks source link

feat: add provider function to improve build size and tree-shaking #217

Closed osnoser1 closed 1 year ago

osnoser1 commented 1 year ago

What are you adding/fixing? A new provider function that imports only services without components and will reduce the final bundle size of the application.

Before:

image

After: image

Have you added tests for your changes? Nop. 😞

Will this need documentation changes? Yes, I did the changes, but I'm not sure if I updated all the places.

Does this introduce a breaking change? Nop, it is a non breaking change 😄

Other information Nope.

netlify[bot] commented 1 year ago

Deploy Preview for ngx-stripe ready!

Name Link
Latest commit 8665d2bee3ed483d54dde54552c06da6b7ea8dfb
Latest deploy log https://app.netlify.com/sites/ngx-stripe/deploys/6498b1243451330008e551d8
Deploy Preview https://deploy-preview-217--ngx-stripe.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

richnologies commented 1 year ago

@osnoser1 thank you so much for this significant contribution.

I'm making some final tests over the weekend and I want to improve the docs a little bit. I'll be issuing a new version 16.2.0 with this feature

Thanks again

osnoser1 commented 1 year ago

@osnoser1 thank you so much for this significant contribution.

I'm making some final tests over the weekend and I want to improve the docs a little bit. I'll be issuing a new version 16.2.0 with this feature

Thanks again

Perfect @richnologies, it's a pleasure to contribute, thanks to you 😄💪🏼