search

richnologies / ngx-stripe

Angular 6+ wrapper for StripeJS
MIT License
219 stars 77 forks source link

Angular 7 Support #45

Closed andervander closed 5 years ago

andervander commented 6 years ago

Please update library to support angular v7

warning " > ngx-stripe@6.0.0-rc.0" has incorrect peer dependency "@angular/common@^6.0.0-rc.1". warning " > ngx-stripe@6.0.0-rc.0" has incorrect peer dependency "@angular/core@^6.0.0-rc.1".

ghost commented 5 years ago

npm i rxjs-compat lets me use with v7 for now

iCodr8 commented 5 years ago

Using npm i rxjs-compat is not a good idea, because the goal of angular 7 is to remove this package.

iCodr8 commented 5 years ago

https://github.com/richnologies/ngx-stripe/issues/51

ghost commented 5 years ago

Using npm i rxjs-compat is not a good idea, because the goal of angular 7 is to remove this package.

Hence the "for now".

ghost commented 5 years ago

Yeah so I'm done with this library. Irresponsible to start a library like this, get 3,000+ weekly downloads, and abandon it.

I pulled the source into my own project and aggressively refactored. Ended up with something much simpler, only 3 files, and now I have control over it.

astr0sl0th commented 5 years ago

@electric-ladyland Care to share?

richnologies commented 5 years ago

That should be fixed in the new version 7.x that has just been published in npm. Please update to the latest version and if the problem persists please open a new issue to let me know.