search

richnologies / ngx-stripe

Angular 6+ wrapper for StripeJS
MIT License
219 stars 77 forks source link

uBlock Origin blocking Stripe element input #53

Closed ghost closed 5 years ago

ghost commented 5 years ago

Anyone else noticed this? I know it's caused by uBlock origin so the problem is caused "there". And not necessarily related to this ngx implemention. But how are others dealing with this? This adblocker has 10 million+ users. So it's a serious issue and I can't find any info about it online. Is Stripe Elements doing something questionable that leads it to be blocked? image

sambokai commented 5 years ago

Related: stripe/react-stripe-elements#222 https://github.com/stripe/stripe-php/issues/528 https://github.com/stripe/react-stripe-elements/issues/256

ghost commented 5 years ago

Interesting links, but I'm not able to see what the conclusion was. Problem with adblocking extensions? Problem with Stripe? Problem with Elements?

I honestly can't believe this isn't a hotter issue... That would make me guess it's some rare version combination of any of the above that have the issue.

In any case, any advice?

sambokai commented 5 years ago

Interesting links, but I'm not able to see what the conclusion was.

Me neither. I linked the issues in an effort to increase visibility and decrease divergence.

I honestly can't believe this isn't a hotter issue...

I agree

That would make me guess it's some rare version combination of any of the above that have the issue.

It would be helpful to hear from more people with similar setups.

sambokai commented 5 years ago

It seems like these guys (https://github.com/stripe/react-stripe-elements/issues/222) contacted the AdBlock team, which in turn removed the block.

We should do the same for uBlock Origin and Ghostery (https://github.com/stripe/react-stripe-elements/issues/256).

ghost commented 5 years ago

I don't use Ghostery so if you could handle that, I'll report to uBlock team and update this ticket.

ghost commented 5 years ago

@sambokai I just enabled my uBlock extension again to test it out. I'm just seeing GET requests against https://q.stripe.com/?event= blocked but the charge token was generated OK. Are you seeing different errors? I want to make sure I correctly report it to uBlock.

sambokai commented 5 years ago

@electric-ladyland Same for me:

bildschirmfoto 2019-01-29 um 18 52 35

I don't use Ghostery either, but it seems to work again. I tested 4 adblockers and ublock origin was the only blocked one.

ghost commented 5 years ago

I'm going to close this then as doesn't look like we need to do anything. uBlock blocks some events but still works. Anyone feel free to reopen.