search

richnologies / ngx-stripe

Angular 6+ wrapper for StripeJS
MIT License
219 stars 77 forks source link

Fixed PaymentIntent and PaymentMethod integration #66

Closed nickdnk closed 5 years ago

nickdnk commented 5 years ago

What are you adding/fixing? There were a few bugs with the PaymentIntent and PaymentMethod integration, such as missing interface implementations and missing promise wrappers.

Have you added tests for your changes? No.

Will this need documentation changes? No. This is strictly bug fixes.

Does this introduce a breaking change? Yes, but the previous PaymentMethod/PaymentIntent integration didn't work correctly.

Other information I've added the getInstance() method to the Stripe interface to avoid inline imports when compiling the lib. This gave my a lot of issues on older Angular versions.

This is a super time-critical PR, so I'm hoping for a merge quickly.

Thanks. And thanks to @dottodot for doing most of the work here.

richnologies commented 5 years ago

Merged.

Also I invite @nickdnk and @dottodot to become collaborators of the project.