search

richnologies / ngx-stripe

Angular 6+ wrapper for StripeJS
MIT License
219 stars 77 forks source link

Fix Angular 8 peer dependency warning #69

Closed dottodot closed 5 years ago

dottodot commented 5 years ago

What are you adding/fixing?

Not exactly critical but this will get rid of the peer dependency warning for Angular 8

Have you added tests for your changes?

N/A Will this need documentation changes?

No Does this introduce a breaking change?

No Other information

nickdnk commented 5 years ago

I'm actually using this library with Angular 6, where it works fine (at least the parts I'm using). Is there a specific reason we cannot have>=6.0.0 in the peerDeps, @richnologies ?

richnologies commented 5 years ago

Hi @nickdnk not at all. I publish version range you suggest. Thanks again @dottodot

nickdnk commented 5 years ago

@richnologies Set the version to >=6.0.0 <9.0.0 as we don't know if it will work with Angular 9 yet (I assume). Since we're not doing the ^6.0.0 syntax.

richnologies commented 5 years ago

@nickdnk done. Sorry for missing that

nickdnk commented 5 years ago

Cool. I think that'll be fine. Then when Angular 9 releases and you can verify it works there too (or fix whatever doesn't), you can just change 9.0.0 to 10.0.0 :)