search

richnologies / ngx-stripe

Angular 6+ wrapper for StripeJS
MIT License
219 stars 77 forks source link

Angular 8 #70

Closed LoganDark closed 5 years ago

LoganDark commented 5 years ago 
npm WARN ngx-stripe@7.4.0 requires a peer of @angular/common@^7.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN ngx-stripe@7.4.0 requires a peer of @angular/core@^7.0.0 but none is installed. You must install peer dependencies yourself.

Latest version on NPM only wants Angular 7, but I updated to Angular 8.

I believe this should work fine, but I'm still raising the issue.

dottodot commented 5 years ago

This will be fixed by this PR https://github.com/richnologies/ngx-stripe/pull/69 just waiting on a decision on including Angular 6 or not.

LoganDark commented 5 years ago

What do you mean by "including Angular 6"?

I would retain compatibility with it. Angular 6 is only like one year ago.

dottodot commented 5 years ago

Read the PR, I'm referring to having it Angular 6 and above in the peer dependencies.It's currently 7 and above (or will be once merged)

LoganDark commented 5 years ago

@dottodot Yeah, that's what I mean.

I think you should only mandate a newer version when ngx-stripe is truly incompatible with older ones.

richnologies commented 5 years ago

Thanks @dottodot for the PR. Finally I also include Angular 6

nickdnk commented 5 years ago

@richnologies I added a changelog, so you should remember to add your changes to CHANGELOG.md when releasing new versions. Otherwise it would be appropriate to remove that file entirely :)