search

richo / homeassistant-franklinwh

Other
9 stars 6 forks source link

Support generator status in sensors #10

Closed richo closed 5 months ago

richo commented 5 months ago

The information appears to be in the mqtt info payload, shoudl just be a case of pulling it out and interpreting it.

npdsomerhayes commented 5 months ago

I have this working! I was working on this yesterday as one of the main transmission towers feeding the region where I live "fell over"! I had my generator running for about 4 hours yesterday so thought I would have a go at integrating it.

I am a very amateur programmer and I ran into a couple of issues that I asked ChatGPT to help me with it. ChatGPT changed the structure and I want to follow your structure so I will play with it today

richo commented 5 months ago

That's great!

If you need some help, feel free to create a pr with what you have and I can give you a hand getting it mergable :)

On Thu, 20 Jun 2024 at 15:07, npdsomerhayes @.***> wrote:

I have this working! I was working on this yesterday as one of the main transmission towers feeding the region where I live "fell over"! I had my generator running for about 4 hours yesterday so thought I would have a go at integrating it.

I am a very amateur programmer and I ran into a couple of issues that I asked ChatGPT to help me with. ChatGPT changed the structure and I want to follow your structure so I will play with it today

— Reply to this email directly, view it on GitHub https://github.com/richo/homeassistant-franklinwh/issues/10#issuecomment-2181635713, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADUKAQGJQM5PB3QDTRTW3DZINHBXAVCNFSM6AAAAABJUQRO62VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOBRGYZTKNZRGM . You are receiving this because you authored the thread.Message ID: @.***>

npdsomerhayes commented 5 months ago

I think I have created a pr (I have not done one before!) let me know if you don't get it and I will try to work out what I did wrong

richo-anyscale commented 5 months ago

I see the branch on your fork, but you haven't created the PR yet. If you like, I can just go grab and pull it in but if you want the full experience, I think if you visit https://github.com/npdsomerhayes/homeassistant-franklinwh you should see a "Create pull request" banner somewhere near the top.

richo commented 5 months ago

Closed by https://github.com/richo/homeassistant-franklinwh/commit/17b45a8314b70e6ac2133dba64e6deb1a230eee9