search

richo / homeassistant-franklinwh

Other
9 stars 6 forks source link

Add battery charge & discharge totals to Sensor.py for use in Home Assistant energy page. #9

Closed slackwilson closed 5 months ago

slackwilson commented 5 months ago

Feel free to change the naming if you like, all I did was add in the 2 sensors for charge & discharge in kWh

richo commented 5 months ago

Looks good! I am gunna change the names just to make them consistent with the others but this is great.

richo commented 5 months ago

Pulled into main, and I updated the class names and property names to make them consistent with what else is there in cd456161e0ee1c66aa3d8ad4bf59ff31b3644cc8, I hope that's ok. Hopefully that doesn't wreak havoc with your install when you pull this in.

slackwilson commented 5 months ago

Yer of course, I was playing around and used some names that I could tell at a glance were the ones I added, as you say better to keep it more consistent :)

slackwilson commented 5 months ago

just an update, the name change caused zero issues - I run those through a Helper because they naturally reset daily just after midnight which the HA energy page doesn't like - and the helper picked up the new names automatically so I didn't have to do anything it just worked.