richonguzman / LoRa_APRS_iGate

LoRa APRS iGATE for ESP32 Based Board with Rx + Tx capabilities
MIT License
212 stars 65 forks source link

qAO substring is misplaced in IS-packet, when string contains a ":" #23

Closed formtapez closed 7 months ago

formtapez commented 8 months ago

Hi, when the string representation of the coordinates contains a ":", the placement of the "qAO"+Callsign substring is inserted at the wrong place in the IS-outputstream, which results in wrong coordinates placed at the other side of the planet.

Generated packet: DG0UHK-9>APLC13,qAS,DB0BWL-1:!/3z,qAO,DB0BWL-1:`Q6(D>=BQLoRa-APRSCube

Should be: DG0UHK-9>APLC13,qAS,DB0BWL-1:!/3z:`Q6(D>=BQLoRa-APRSCube,qAO,DB0BWL-1

Problem here: https://github.com/richonguzman/LoRa_APRS_iGate/blob/79e88bb03fc1255952885a9c675dffeec10fae2d/src/aprs_is_utils.cpp#L79

richonguzman commented 8 months ago

hi, can you link me where to gather information about having qAS and qAO at the same packet?

this is new to me

formtapez commented 8 months ago

I got it from here: https://aprs.fi/?c=raw&call=DG0UHK-9&limit=500&view=normal (login needed)

image

formtapez commented 8 months ago

Same packet via syslog: Jan 12 14:43:37 nat.db0bwl.ampr.org ESP32 LoRa [APRS] - DB0BWL-1 - LoRa Rx - GPS - DG0UHK-9 / APLC13 / _ / -104dBm / -17.50dB / 434Hz / 52.45038N / 10.82962E / 9.0km btw, im using firmware version 2023.12.07 in which you changed to packet.indexOf(":`")) and then changed it back later. maybe that bug is already gone in newer versions?

richonguzman commented 8 months ago

the change or not of. ":´" shouldn't affect the other packets

the really strange thing is that syslog is doing its job nicely but the upload into aprs-is is faulty with this.

besides the "qAS" that is not being produced by my/this firmware...

will need to dig a little more about it

formtapez commented 8 months ago

As you see (received by DO2DE-10) one packet before and after our incident, the string representation of the GPS-coordinates contains an :, at which position our qAO-String was misplaced into. I got that error also 1 or 2 times before, some weeks ago from the same tracker. At roughly the same position on his way to work.

Maybe the other qAS-thing is a consequential error because the whole string was interpreted the wrong way (like the coordinates, too), and inserted by APRS.fi itself afterwards. So i would recommend to focus on the : 😁

richonguzman commented 8 months ago

as I see is something with APLC13 tocall (which I presume is APRSCube)

maybe I miss some packet decofication of it that my FW is not filtering right the packet payload, will check it out

Mane76 commented 8 months ago

I think this is a different issue. Note the :` is a MIC-E encoded paket. We also have seen the issue that sometimes it is appened as comment. Please update to the latest version as it should be solved. I currently test MIC-E and no problems at all.

richonguzman commented 7 months ago

the fix was added as the packet upload process was fixed

formtapez commented 7 months ago

Sorry i forgot to come back here to confirm that updating the firmware has completely fixed that problem. Thanks!