richorama / country-code-lookup

:earth_africa: Finds countries by various country codes
MIT License
84 stars 28 forks source link

can't lookup ByCountry for #20

Closed dixitk13 closed 4 years ago

dixitk13 commented 4 years ago

I was just trying to use the library, looks like the following countries aren't returning for byCountry method:

[
  "UK",
  "S. Korea",
  "Czechia",
  "UAE",
  "Hong Kong",
  "Channel Islands",
  "Palestine",
  "DRC",
  "Faeroe Islands",
  "Brunei ",
  "Congo",
  "Bahamas",
  "Macao",
<--didn't read after this -->
  "Myanmar",
  "St. Vincent Grenadines",
  "MS Zaandam",
  "Gambia",
  "Turks and Caicos",
  "Cabo Verde",
  "CAR",
  "Vatican City",
  "St. Barth",
  "Falkland Islands",
  "Caribbean Netherlands",
  "Saint Pierre Miquelon"
]

M not sure, if all of these are valid countries. Feel free to close iff not.

richorama commented 4 years ago

I think your country names don’t quite line up. It’s ‘United Kingdom’ for example.

Sent from my iPhone

On 13 Apr 2020, at 15:09, Dixit Keshavbhai Patel notifications@github.com wrote:

 I was just trying to use the library, looks like the following countries aren't returning for byCountry method:

[ "UK", "S. Korea", "Czechia", "UAE", "Hong Kong", "Channel Islands", "Palestine", "DRC", "Faeroe Islands", "Brunei ", "Congo", "Bahamas", "Macao", <--didn't read after this --> "Myanmar", "St. Vincent Grenadines", "MS Zaandam", "Gambia", "Turks and Caicos", "Cabo Verde", "CAR", "Vatican City", "St. Barth", "Falkland Islands", "Caribbean Netherlands", "Saint Pierre Miquelon" ] M not sure, if all of these are valid countries. Feel free to close iff not.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe.

TriBuiQuang commented 4 years ago

Dear mr. Richorama, i can't look up country "Hong Kong" , it's return null when i search it , but in https://www.iban.com/country-codes , they had , can you fix it ?

richorama commented 4 years ago

It was in as Hong Kong (China) - I have fixed this and republished. Thanks for letting me know!