Closed cclauss closed 2 years ago
I agree that there is a lot of shoddy code out there and we should be encouraging people to properly test and validate their code, but I'm a little nervous about making all of those tools mandatory. At the end of the day, this is a hobbyist project and I don't want to raise the bar too high for people to contribute. I'm aware that I'm not familiar with the tools you have listed so this is partly my own ignorance talking here too.
I shall definitely check these tools out and get more familiar with them. But until then I'm nervous about mandating their use.
Slim down to just a few tools
Test results: https://github.com/cclauss/PyBasic/actions
bandit, codespell, flake8, mypy, pytest, and safety are all currently setup as mandatory tests.
Fixes a failing doctest:
FlowSignal(ftype=FlowSignal.RETURN).ftarget
isNone
, not-1
$
pytest --doctest-modules .