search

richq / folders2flickr

Upload files to flickr
Other
102 stars 38 forks source link

moved keys to ini file, created sample ini, rm uploader.ini from git #5

Closed lbell closed 10 years ago

lbell commented 10 years ago

Cleaning up the hard-coded keys, and attempting to make this project more multi-user friendly. Moved the api_key and secret to uploadr.ini. Also, removed uploader.ini from git (added to gitignore) and created a blank sample / template for uploadr.ini

richq commented 10 years ago

I like the look of this, thanks for taking the time to improve all this messy stuff. Probably merge 2moro when I'm at a PC. Happy new year ;)

On 12/31/13, LBell notifications@github.com wrote:

Cleaning up the hard-coded keys, and attempting to make this project more multi-user friendly. Moved the api_key and secret to uploadr.ini. Also, removed uploader.ini from git (added to gitignore) and created a blank sample / template for uploadr.ini You can merge this Pull Request by running:

git pull https://github.com/lbell/folders2flickr ini_mod

Or you can view, comment on it, or merge it online at:

https://github.com/richq/folders2flickr/pull/5

-- Commit Summary --

  • moved keys to ini file, created sample ini

-- File Changes --

M .gitignore (3)
M f2flickr/uploadr.py (6)
D uploadr.ini (23)
A uploadr.ini.sample (33)

-- Patch Links --

https://github.com/richq/folders2flickr/pull/5.patch https://github.com/richq/folders2flickr/pull/5.diff

lbell commented 10 years ago

Anyway - I'm not wedded to any of this - just trying to minimize the number of places I have to make changes as things update...

richq commented 10 years ago

OK, no problem. Xmas hols are over now, which is why I've not merged this yet. This weekend I'll pull this change in and fiddle about to get a balance between your use case (which I hadn't considered, but makes perfect sense) and something user-friendly.

On 1/3/14, LBell notifications@github.com wrote:

Anyway - I'm not wedded to any of this - just trying to minimize the number of places I have to make changes as things update...

Reply to this email directly or view it on GitHub: https://github.com/richq/folders2flickr/pull/5#issuecomment-31503128

richq commented 10 years ago

This is merged now, with a minor tweak to avoid having to add in keys to the ini file if you already are using things as-is. thanks!

lbell commented 10 years ago

Nice - I like it. Thanks.